Conversation
Contributor
vnandwana
commented
Jul 15, 2025
vnandwana
commented
- Added a method to RuntimeConfigRegistry to clear runtime configuration state.
- Replaced references to ConfigurationObjectFactory with AugmentedConfigurationObjectFactory where applicable.
Added RuntimeConfigRegistry, used it in ConfigurationObjectFactory.
sbrossie
approved these changes
Jul 16, 2025
Member
sbrossie
left a comment
sbrossie
left a comment
There was a problem hiding this comment.
Looks fine. If I understand correctly, the main diff is the systematic use of AugmentedConfigurationObjectFactory in the tests, and the introduction of the RuntimeConfigRegistry#clear() method.
@vnandwana Do you know what the issue was?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.